Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trio-run-in-process, use pure trio process spawner, test out of channel ctrl-c subactor cancellation #128

Merged
merged 20 commits into from
Jul 27, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix SIGINT test names
goodboy committed Jul 27, 2020
commit 3c7ec72f8e04f929f0a16be3434755e52fb9dbde
4 changes: 2 additions & 2 deletions tests/test_cancellation.py
Original file line number Diff line number Diff line change
@@ -359,7 +359,7 @@ async def test_nested_multierrors(loglevel, start_method):


@no_windows
def test_open_in_proc_cancel_via_SIGINT(loglevel, start_method):
def test_cancel_via_SIGINT(loglevel, start_method):
"""Ensure that a control-C (SIGINT) signal cancels both the parent and
child processes in trionic fashion
"""
@@ -377,7 +377,7 @@ async def main():


@no_windows
def test_open_in_proc_cancel_via_SIGINT_other_task(
def test_cancel_via_SIGINT_other_task(
loglevel,
start_method
):
1 change: 0 additions & 1 deletion tractor/_entry.py
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@ def _mp_main(
forkserver_info: Tuple[Any, Any, Any, Any, Any],
start_method: str,
parent_addr: Tuple[str, int] = None,
infect_asyncio: bool = False,
) -> None:
"""The routine called *after fork* which invokes a fresh ``trio.run``
"""
2 changes: 0 additions & 2 deletions tractor/_spawn.py
Original file line number Diff line number Diff line change
@@ -189,7 +189,6 @@ async def new_proc(
bind_addr: Tuple[str, int],
parent_addr: Tuple[str, int],
use_trio_run_in_process: bool = False,
infect_asyncio: bool = False,
task_status: TaskStatus[Portal] = trio.TASK_STATUS_IGNORED
) -> None:
"""Create a new ``multiprocessing.Process`` using the
@@ -275,7 +274,6 @@ async def new_proc(
fs_info,
start_method,
parent_addr,
infect_asyncio,
),
# daemon=True,
name=name,