-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop run #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lol of course I was able to reproduce if you run: Seems like some poll hang on shutdown... ^CError in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/popen_fork.py", line 27, in poll
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
Closing all actor lifetime contexts
pid, sts = os.waitpid(self.pid, flag)
KeyboardInterrupt
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close'
Exception ignored in: <Finalize object, dead>
Traceback (most recent call last):
File "/usr/lib/python3.9/multiprocessing/util.py", line 224, in __call__
File "/usr/lib/python3.9/multiprocessing/util.py", line 464, in close_fds
AttributeError: 'NoneType' object has no attribute 'close' Might have to delay the full |
Merged
519e85f
to
9fd3047
Compare
Gonna try rebasing this onto #206 to see if we lose wtv race conditions were making mp 🤮 |
b5df6f2
to
3de2e9e
Compare
3a64e64
to
87971de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should start resolving the following:
tractor.run()
#183rpc_module_paths
->enable_modules
? #182tractor.run()
is going to require a big edit of the test set and examples.tractor_test
is going to need to be redonetrio.run()
#168