Root tty hangs #234
Merged
Root tty hangs #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to squash / drop a few of these commits. |
We're not actually using this but it's for reference if we do end up needing it. The std lib's `pdb` internals override SIGINT handling whenever one enters the debugger repl. Force a handler that kills the tree if SIGINT is triggered from the root actor, otherwise ignore it since supervised children should be managed already. This resolves an issue with guest mode where `pdb` causes SIGINTs to be swallowed resulting in the host loop never terminating the process tree.
Always try to release the root tty lock on broken connection errors.
goodboy
force-pushed
the
root_tty_hangs
branch
from
26de034 to
e083362
Compare
goodboy
force-pushed
the
root_tty_hangs
branch
from
e083362 to
76342ed
Compare
goodboy
commented
Sep 2, 2021
| @@ -298,8 +298,8 @@ async def _open_and_supervise_one_cancels_all_nursery( | |||
| f'child {_debug._global_actor_in_debug}\n' | |||
| 'Waiting on tty lock to release..') | |||
|
|
|||
| with trio.CancelScope(shield=True): | |||
| await debug_complete.wait() | |||
| # with trio.CancelScope(shield=True): | |||
There was a problem hiding this comment.
We may end up wanting to keep this but right now it's causing too many hangs.
goodboy
commented
Sep 2, 2021
| @@ -62,7 +62,7 @@ def _trio_main( | |||
| """ | |||
| # Disable sigint handling in children; | |||
| # we don't need it thanks to our cancellation machinery. | |||
| signal.signal(signal.SIGINT, signal.SIG_IGN) | |||
| # signal.signal(signal.SIGINT, signal.SIG_IGN) | |||
There was a problem hiding this comment.
Might as well keep for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugger improvements to avoid even further tty clobbering edge cases and potential root actor hangs when the debug lock is acquired but the child completes or intends to release it but the root never is notified.