Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the argument type of terminate_fn to AsyncEnv so that the is_successful function of TaskEval can be used as terminate_fn. #211

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 15, 2025

Changing the argument type of terminate_fn to AsyncEnv so that the is_successful function of TaskEval can be used as terminate_fn.

Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@copybara-service copybara-service bot changed the title Fix the bug that termination_fn is passed with the wrong argument. Changing the argument type of terminate_fn to AsyncEnv so that the is_successful function of TaskEval can be used as terminate_fn. Jan 16, 2025
@copybara-service copybara-service bot force-pushed the test_715929660 branch 10 times, most recently from 62b0eb1 to 93bc588 Compare January 16, 2025 21:53
…_successful function of TaskEval can be used as terminate_fn.

PiperOrigin-RevId: 716368342
@copybara-service copybara-service bot merged commit 1ebb875 into main Jan 16, 2025
@copybara-service copybara-service bot deleted the test_715929660 branch January 16, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants