bug fix w.r.t. lookat #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Qwlouse why does this change cause a test failure? |
|
LGTM. Though given that this error did not show up before, we should probably add some additional tests for this. |
gabriel-v
added a commit
to gabriel-v/kubric
that referenced
this pull request
Apr 20, 2022
This reverts commit a3d5eaa. This is because on the new blender 3.1.2, with this patch applied, the camera is rotated with its up side pointing to the right.
MrXandbadas
added a commit
to MrXandbadas/kubric
that referenced
this pull request
May 26, 2022
An attempt to help with google-research#197 google-research#198 Created a new function in Kubric core. set_position() I hope this is helpful xD
MrXandbadas
added a commit
to MrXandbadas/kubric
that referenced
this pull request
May 26, 2022
An attempt to help with google-research#197 google-research#198 Created a new function in Kubric core. set_position() I hope this is helpful xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197