Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to use parenting instead of joining when loading GLB. #338

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

burrussmp
Copy link
Collaborator

Adds the ability to use parenting instead of joining when loading GLB.

NOTE: Intentionally left out "glb_" prefix to option as this could eventually be applied to other filetypes on load, for example, USD.

NOTE: Intentionally left out "glb_" prefix to option as this could eventually be applied to other filetypes on load, for example, USD.
PiperOrigin-RevId: 700816151
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (a9e4113) to head (d9b547e).

Files with missing lines Patch % Lines
kubric/renderer/blender.py 4.1% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #338     +/-   ##
=======================================
- Coverage   65.9%   65.7%   -0.3%     
=======================================
  Files         43      43             
  Lines       3582    3596     +14     
=======================================
+ Hits        2361    2363      +2     
- Misses      1221    1233     +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kubric/renderer/blender.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Qwlouse Qwlouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot for implementing this.

@burrussmp burrussmp merged commit 0ee21e2 into main Nov 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants