Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the locale dependent date parsing used for the output heap trace … #138

Conversation

lukastvrdy
Copy link
Contributor

…filename

date/T prints the date in locale-dependent format and thus causes issues when being parsed.
wmic command works independently of OS locale, language or the user's chosen date format.

…filename

date/T prints the date in locale-dependent format and thus causes issues when being parsed.
wmic command works independently of OS locale, language or the user's chosen date format.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lukastvrdy
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@randomascii
Copy link
Contributor

Sorry for the delayed response - I went on vacation the day you uploaded this. I'm hitting some problems with the find command but I think that's just because I've got a non-standard find command in my path. I will look more closely later.

@randomascii randomascii merged commit a4b358a into google:master Dec 9, 2019
@randomascii
Copy link
Contributor

The find problem was unrelated. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants