This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Updates to reflect the latest Workbox webpack plugin options. #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops! There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed. WARNINGS |
|
@gauntface - feel free to merge when you're happy. |
gauntface
approved these changes
Jan 19, 2018
|
🎉 This has been pushed live to https://developers.google.com/web/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the module guide for for the Workbox webpack plugin in line with the syntax and supported options in the latest v3 alpha.
Fixes #5567
Target Live Date: 2018-01-22
gulp testlocally and all tests pass.type-somethinglabel.CC: @petele @gauntface @addyosmani