Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Another update to skipWating recipe #8696

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes GoogleChrome/workbox#2430

We'll need to update this again in v6 to use the new messageSkipWaiting() method, but this should hopefully be sufficient for v4/v5 users.

@WebFundBot
Copy link

Whoops!

There were 10 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/tools/workbox/guides/advanced-recipes.md#L21 - '<script> tags are generally not allowed, please double check.
src/content/en/tools/workbox/guides/advanced-recipes.md#L368 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/tools/workbox/guides/advanced-recipes.md#L96 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L114 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L141 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L187 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L258 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L284 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L345 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/workbox/guides/advanced-recipes.md#L184 - Line must be at most 100 characters

@jeffposnick jeffposnick merged commit ee43d5f into master May 8, 2020
@jeffposnick jeffposnick deleted the wb-skipWaiting-update-again branch May 8, 2020 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated offer page reload recipe seems to contain broken code
4 participants