Topics in OpenRTB document: Upgrade suggestions at bottom of .md file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbelov
reviewed
Jun 30, 2022
review feedback
sbelov
reviewed
Jul 6, 2022
proposals/topics-rtb/README.md
Outdated
| ] | ||
| } | ||
| "segtax": 600, | ||
| "segclass": "v1" |
There was a problem hiding this comment.
I believe this was meant to be either v2 or class_v2?
We may also want to make the classifier names in the example consistent between what Chromium might return and what gets populated into the segclass extension field.
There was a problem hiding this comment.
sure, I used example feedback from prebid/Prebid.js#8630 (comment) provided by @vkimcm
patmmccann
commented
Jul 8, 2022
| @@ -9,103 +9,69 @@ | |||
| | Attributes | Type | Description | | |||
| | ------------ | ----------- | ----------- | | |||
| | Taxonomy Version | String | Represents the version of the topic’s categories. | | |||
| | Classifier Version | String | Represents the version of the classifier used to categorize sites. | | |||
| | Model Version | String | Represents the version of the classifier model used to categorize sites. | | |||
There was a problem hiding this comment.
from live api feedback documented here prebid/Prebid.js#8630 (comment)
sbelov
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.