Address review

google · Nov 12, 2024 · 8e8ad2e · 8e8ad2e
2 parents 066914a + 11ed6f0
commit 8e8ad2e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/catalog/src/main/assets/component_modal.json b/catalog/src/main/assets/component_modal.json
@@ -17,7 +17,7 @@
           }
         },
         {
-          "url": "https://github.com/google/android-fhir/dialog"
+          "url": "https://github.com/google/android-fhir/StructureDefinition/dialog"
         }
       ],
       "linkId": "1.1",

diff --git a/...in/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt b/...in/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
@@ -62,7 +62,7 @@ internal const val EXTENSION_ITEM_CONTROL_SYSTEM_ANDROID_FHIR =
   "https://github.com/google/android-fhir/questionnaire-item-control"
 
 internal const val EXTENSION_DIALOG_URL_ANDROID_FHIR =
-  "https://github.com/google/android-fhir/dialog"
+  "https://github.com/google/android-fhir/StructureDefinition/dialog"
 
 internal enum class StyleUrl(val url: String) {
   BASE("https://github.com/google/android-fhir/tree/master/datacapture/android-style"),

diff --git a/...capture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireEditAdapterTest.kt b/...capture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireEditAdapterTest.kt
@@ -497,9 +497,8 @@ class QuestionnaireEditAdapterTest {
       .isEqualTo(QuestionnaireViewHolderType.DROP_DOWN.value)
   }
 
-  @Suppress("ktlint:standard:max-line-length")
   @Test
-  fun getItemViewType_choiceItemType_itemControlExtensionWithRadioButton_andDialogExtension_shouldReturnDialogSelectViewHolderType() {
+  fun `getItemViewType() with choice, radio button, and dialog extension should return dialog select view holder type`() {
     val questionnaireEditAdapter = QuestionnaireEditAdapter()
     val questionnaireItem =
       Questionnaire.QuestionnaireItemComponent().setType(Questionnaire.QuestionnaireItemType.CHOICE)
@@ -536,9 +535,8 @@ class QuestionnaireEditAdapterTest {
       .isEqualTo(QuestionnaireViewHolderType.DIALOG_SELECT.value)
   }
 
-  @Suppress("ktlint:standard:max-line-length")
   @Test
-  fun getItemViewType_choiceItemType_itemControlExtensionWithCheckBox_andDialogExtension_shouldReturnDialogSelectViewHolderType() {
+  fun `getItemViewType() with choice, check box, and dialog extension should return dialog select view holder type`() {
     val questionnaireEditAdapter = QuestionnaireEditAdapter()
     val questionnaireItem =
       Questionnaire.QuestionnaireItemComponent().setType(Questionnaire.QuestionnaireItemType.CHOICE)
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,7 @@ @@
               }
             },
             {
-              "url": "https://github.com/google/android-fhir/dialog"
+              "url": "https://github.com/google/android-fhir/StructureDefinition/dialog"
             }
           ],
           "linkId": "1.1",
@@ Expand Down @@