Answer expression catalog #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimoonak
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
|
I will do an initial review, thanks! |
catalog/src/main/java/com/google/android/fhir/catalog/CatalogApplication.kt
Outdated
Show resolved
Hide resolved
…pplication.kt Co-authored-by: santosh-pingle <[email protected]>
aditya-07
previously requested changes
Jul 19, 2023
catalog/src/main/java/com/google/android/fhir/catalog/CatalogApplication.kt
Outdated
Show resolved
Hide resolved
…p/android-fhir into answer-expression-catalog
jingtang10
requested changes
Sep 12, 2023
...apture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt
Outdated
Show resolved
Hide resolved
|
@jingtang10 I have resolved the feedback. The kokoro build is failing due to tests but I do not see any specific issue in logs. Looks like it passess on one device and fails on other |
jingtang10
approved these changes
Oct 2, 2023
jingtang10
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Answer expression catalog entry to see usage of the expression
Description
Answer expression is a complex expression which needs a demonstration of usage into catalog.
Type
Choose one: Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.