make sure we're using the cxx17 check correctly

google · Jan 8, 2025 · 9f4be47 · 9f4be47
1 parent 59e7cd7
commit 9f4be47
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/include/benchmark/benchmark.h b/include/benchmark/benchmark.h
@@ -171,6 +171,8 @@ BENCHMARK(BM_test)->Unit(benchmark::kMillisecond);
 // This _MSC_VER check should detect VS 2017 v15.3 and newer.
 #if __cplusplus >= 201703L || \
     (defined(_MSC_VER) && _MSC_VER >= 1911 && _MSVC_LANG >= 201703L)
+// CXX17 implies CXX11
+#define BENCHMARK_HAS_CXX11
 #define BENCHMARK_HAS_CXX17
 #endif
 

diff --git a/src/log.h b/src/log.h
@@ -11,6 +11,14 @@
 #define BENCHMARK_HAS_CXX11
 #endif
 
+// This _MSC_VER check should detect VS 2017 v15.3 and newer.
+#if __cplusplus >= 201703L || \
+    (defined(_MSC_VER) && _MSC_VER >= 1911 && _MSVC_LANG >= 201703L)
+// CXX17 implies CXX11
+#define BENCHMARK_HAS_CXX11
+#define BENCHMARK_HAS_CXX17
+#endif
+
 namespace benchmark {
 namespace internal {