Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSVReporter giving Wdeprecated-declarations warning from inside benchmark.cc #608

Closed
astrelni opened this issue May 31, 2018 · 0 comments
Closed

CSVReporter giving Wdeprecated-declarations warning from inside benchmark.cc #608

astrelni opened this issue May 31, 2018 · 0 comments
Assignees
@dmah42

Comments

@astrelni
Copy link
Contributor

CSVReporter is marked deprecated as of #488, but the type is still used inside benchmark.cc https://github.com/google/benchmark/blob/master/src/benchmark.cc#L451, breaking -Werror builds.
@dmah42 dmah42 self-assigned this May 31, 2018
dmah42 added a commit that referenced this issue May 31, 2018
@dmah42
Disable deprecation warnings when -Werror is enabled.
3cdd5ab 
Fixes #608
@dmah42 dmah42 mentioned this issue May 31, 2018
Merged
dmah42 pushed a commit that referenced this issue Jun 7, 2018
@dominichamon
Disable deprecation warnings when -Werror is enabled. (#609)
151ead6 
Fixes #608
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this issue Dec 6, 2018
@dominichamon
Disable deprecation warnings when -Werror is enabled. (google#609)
133c739 
Fixes google#608
@felipecrv felipecrv mentioned this issue Nov 12, 2019
Merged
@tehbelinda tehbelinda mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmah42 dmah42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmah42 @astrelni