Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescaped commas in CSV output #170

Closed
chrisroman opened this issue Aug 7, 2019 · 1 comment · Fixed by #174
Closed

Unescaped commas in CSV output #170

chrisroman opened this issue Aug 7, 2019 · 1 comment · Fixed by #174

Comments

@chrisroman
Copy link

When running ./bloaty bloaty --csv, I get the following output:

sections,vmsize,filesize
__TEXT,__const,2151456,2151456
__TEXT,__text,1321560,1321560
__DATA,__bss,1050450,0
__DATA,__data,449104,449104
String Table,325048,325048
__DATA,__const,305856,305856
Symbol Table,248208,248208
__TEXT,__cstring,95128,95128
Export Info,43544,43544
__TEXT,__gcc_except_tab,19040,19040
__TEXT,__unwind_info,11968,11968
[10 Others],11880,9762
Lazy Binding Info,9568,9568
Weak Binding Info,4784,4784
[__TEXT],4734,4630
Binding Info,3824,3824
Function Start Addresses,3304,3304
__TEXT,__eh_frame,3304,3304
[__LINKEDIT],3008,0
Rebase Info,2264,2264
Indirect Symbol Table,2240,2240

However, if you look at the 2nd row __TEXT,__const,2151456,2151456, you'll see that the section name is __TEXT,__const which messes up the CSV formatting. I would expect it to be something like "__TEXT,__const",2151456,2151456.

This is also the case when adding the -d compileunits.

@haberman
Copy link
Member

This is a silly error in the code. The code defines CSVEscape() but does not use it.

haberman added a commit to haberman/bloaty that referenced this issue Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants