Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to Blockly.FieldColour from keyboard-navigation #2382

Closed
1 task done
maribethb opened this issue May 31, 2024 · 3 comments · Fixed by #2441
Closed
1 task done

remove references to Blockly.FieldColour from keyboard-navigation #2382

maribethb opened this issue May 31, 2024 · 3 comments · Fixed by #2441
Assignees
Labels
good first issue Good for newcomers type: bug Something isn't working

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

keyboard-navigation

Description

The keyboard navigation attempts to patch Blockly.FieldColour. That field no longer exists, so even referencing it causes webpack warnings.

To fix

  1. In navigation_controller.ts, remove the lines that attempt to add or remove the onShortcut handler to Blockly.FieldColour.
  2. In the same file, remove the now-unused fieldColourHandler function.

If you'd like to work on this issue see also our contributing docs and comment here saying that you'd like to work on this.

Reproduction steps

  1. Run npm run build in plugins/keyboard-navigation
  2. Notice warnings about how Blockly.FieldColour doesn't exist

Stack trace

No response

Screenshots

No response

@maribethb maribethb added type: bug Something isn't working triage good first issue Good for newcomers and removed triage labels May 31, 2024
@Vishesh-Paliwal
Copy link
Contributor

hey @BeksOmega , Can I get assigned for this issue . I would love to work on it

@BeksOmega
Copy link
Contributor

Go for it @Vishesh-Paliwal =) Let me know if you have any questions!

@Vishesh-Paliwal
Copy link
Contributor

Thanks @BeksOmega for assigning . Raised a PR for the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
3 participants