fix: scroll-options stops using is3dSupported #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested changes
Nov 10, 2022
Signed-off-by: Hollow Man <[email protected]>
|
Fixed, thanks for reviewing! |
HollowMan6
requested review from
rachel-fenichel
and removed request for
NeilFraser
rachel-fenichel
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on:
is3dSupportedblockly#6400As
is3dSupportedhas been removed in Blockly 9, the workspace-multiselect plugin v0.1.3 will choose to use "Blockly.WorkspaceSvg.getBlockDragSurfacealways returnnull" to disable dragsurface, which means now it's OK to removeis3dSupportedhere in scroll-options.Also fix the plugin to get the workspace translation when there's no getBlockDragSurface.
Signed-off-by: Hollow Man [email protected]