chore: fix tests failures

google · Jan 5, 2023 · 8cb14d4 · 8cb14d4
1 parent 63f7929
commit 8cb14d4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/blocks/procedures.js b/blocks/procedures.js
@@ -581,7 +581,8 @@ const procedureDefMutator = {
       if (node.nodeName.toLowerCase() !== 'arg') continue;
       this.getProcedureModel().insertParameter(
           new ObservableParameterModel(
-              this.workspace, node.getAttribute('name')),
+              this.workspace, node.getAttribute('name'),
+              node.getAttribute('varid')),
           i);
     }
 
@@ -645,11 +646,13 @@ const procedureDefMutator = {
    *     statements.
    */
   loadExtraState: function(state) {
-    for (let i = 0; i < state['params'].length; i++) {
-      const param = state['params'][i];
-      this.getProcedureModel().insertParameter(
-          new ObservableParameterModel(this.workspace, param.name, param.id),
-          i);
+    if (state['params']) {
+      for (let i = 0; i < state['params'].length; i++) {
+        const param = state['params'][i];
+        this.getProcedureModel().insertParameter(
+            new ObservableParameterModel(this.workspace, param.name, param.id),
+            i);
+      }
     }
 
     // TODO: Remove this data update code.
@@ -815,8 +818,8 @@ Extensions.registerMixin(
 const procedureDefOnChangeMixin = {
   onchange: function(e) {
     if (e.type === Events.BLOCK_CHANGE && e.blockId === this.id &&
-        e.element == 'disabled') {
-      this.model.setEnabled(!e.newValue);
+        e.element === 'disabled') {
+      this.getProcedureModel().setEnabled(!e.newValue);
     }
   },
 };

diff --git a/core/procedures/observable_parameter_model.ts b/core/procedures/observable_parameter_model.ts
@@ -24,8 +24,8 @@ export class ObservableParameterModel implements IParameterModel {
   constructor(
       private readonly workspace: Workspace, name: string, id?: string) {
     this.id = id ?? genUid();
-    this.variable =
-        this.workspace.getVariable(name) ?? workspace.createVariable(name);
+    this.variable = this.workspace.getVariable(name) ??
+        workspace.createVariable(name, '', id);
   }
 
   /**