Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what to do about output shape on the block #3414

Closed
samelhusseini opened this issue Nov 7, 2019 · 2 comments
Closed

Decide what to do about output shape on the block #3414

samelhusseini opened this issue Nov 7, 2019 · 2 comments
Assignees
@samelhusseini
Labels
component: rendering issue: feature request Describes a new feature and why it should be added
Milestone
2019_q4_release

Comments

@samelhusseini
Copy link
Contributor

Zelos blocks sometimes set the output shape in JS (by calling block.setOutputShape). We should decide what to do about those blocks that want to specify the output shape explicitly and not use the shapeFor method to dynamically decide what shape to use.
@samelhusseini samelhusseini added issue: feature request Describes a new feature and why it should be added component: rendering issue: triage Issues awaiting triage by a Blockly team member labels Nov 7, 2019
@moniika moniika added this to the 2019_q4_release milestone Nov 11, 2019
@moniika moniika removed the issue: triage Issues awaiting triage by a Blockly team member label Nov 11, 2019
@samelhusseini samelhusseini mentioned this issue Dec 5, 2019
Merged
3 tasks
@rachel-fenichel
Copy link
Collaborator

The task here is to add setOutputShape as a function on a block

@samelhusseini samelhusseini self-assigned this Jan 6, 2020
@samelhusseini samelhusseini mentioned this issue Jan 7, 2020
Merged
3 tasks
@samelhusseini
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samelhusseini samelhusseini

Labels
component: rendering issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
2019_q4_release
Development

No branches or pull requests
3 participants
@moniika @rachel-fenichel @samelhusseini