Add output shape on a block. Add squared shape. #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alschmiedt I've fixed up the comments for how all the shapes are drawn (rounded, hexagonal and squared). Let me know if those comments make sense. |
|
Also a picture would be nice... |
|
Sample of a square shaped block: |
alschmiedt
reviewed
Jan 7, 2020
moniika
pushed a commit
to moniika/blockly
that referenced
this pull request
Jan 10, 2020
* Add output shape on the block. Add squared shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #3414
Proposed Changes
Add ouput shape property on a block and parse from json.
Add implementation for a square shape in zelos.
Use a block's output shape if one exists when deciding on what shape to use.
Reason for Changes
Zelos rendering.
Test Coverage
Tested with pxt-blockly blocks in zelos rendering playground.
Tested on:
Documentation
Additional Information