Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutator bubble gets misconfigured if sub-block gets wider #4086

Closed
joseluiz98 opened this issue Jul 29, 2020 · 2 comments · Fixed by #6917
Closed

Mutator bubble gets misconfigured if sub-block gets wider #4086

joseluiz98 opened this issue Jul 29, 2020 · 2 comments · Fixed by #6917
Assignees
Labels
component: bubbles issue: bug Describes why the code or behaviour is wrong

Comments

@joseluiz98
Copy link

Describe the bug
If a flyout block gets wider inside a mutator bubble for any reasons (e.g a wider dropdown option label), the flyout width doesn't resize itself, this causes a mix between the bubble flyout and the bubble workspace, a 'weird' behavior for the user.

To Reproduce

Just create a simple mutator on a block, in this block put a FieldDropdown with two options - one with a short label (e.g 'test'), and another one with a much wider option (e.g 'testing this bubble mutator grow ability), and see the magic.

Expected behavior

I have two behaviors in mind that, for me, solve this problem:

1- Grow up the bubble as its contents get wider
2- Implement a 'ellipsis' such as CSS have the 'ellipsis-overflow' option, basically, the dropdown option would be abbreviate if it's too long.

Screenshots

I made up a quick gif to show this, see:

click here
or click here, to see it bigger

@joseluiz98 joseluiz98 added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Jul 29, 2020
@alschmiedt
Copy link
Contributor

Just some additional context. It looks like the flyout is getting resized, but the position of the block in the workspace and the size of the bubble are not getting updated properly.

Shows the flyout a bit better:
3e2653af-9ff0-414a-96a4-c6733af6a368

@alschmiedt alschmiedt removed the issue: triage Issues awaiting triage by a Blockly team member label Jul 29, 2020
@alschmiedt alschmiedt added this to the Bug Bash Backlog milestone Jul 29, 2020
@joseluiz98
Copy link
Author

Just some additional context. It looks like the flyout is getting resized, but the position of the block in the workspace and the size of the bubble are not getting updated properly.

Shows the flyout a bit better:
3e2653af-9ff0-414a-96a4-c6733af6a368

Yep, you're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bubbles issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants