fix: flyouts resizing for blocks #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Discovered that flyouts were not being resized when blocks changed size (e.g. changing field values) during investigation of #4086 This was caused by #6860
Proposed Changes
Makes it so that events are always fired after the current frame finishes drawing. This ensures that all blocks have been rendered and their dimensions, positions, connection positions, etc are all updated before event listeners are triggered.
Reason for Changes
Event listeners would be working with info that wasn't up to date because they were triggered too early.
Test Coverage
Just manual testing.
Documentation
N/A
Additional Information
This fixes a regression and should go in before the release.