Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options parser should add trailing slash to 'media' if not present. #6263

Closed
NeilFraser opened this issue Jul 8, 2022 · 0 comments
Closed

options parser should add trailing slash to 'media' if not present. #6263

NeilFraser opened this issue Jul 8, 2022 · 0 comments
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong

Comments

@NeilFraser
Copy link
Contributor

But only if 'media' is not empty (since '' is not the same as '/').

Also, add deprecation warning to usage of 'path' option. That's been deprecated for ~8 years.
@NeilFraser NeilFraser added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited labels Jul 8, 2022
@derwehr derwehr mentioned this issue Jul 12, 2022
Merged
4 tasks
BeksOmega pushed a commit that referenced this issue Jul 12, 2022
@derwehr
fix: options parser should add trailing slash to 'media' if not prese…
bf1a40c 
…nt. (#6263) (#6264)

* fix: add trailing slash to media option

* fix: add deprecation warning to path option
@release-please release-please bot mentioned this issue Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NeilFraser @BeksOmega