Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the blockly icon CSS classes to use camelCase #8329

Closed
BeksOmega opened this issue Jul 11, 2024 · 2 comments
Closed

Rename the blockly icon CSS classes to use camelCase #8329

BeksOmega opened this issue Jul 11, 2024 · 2 comments
Assignees
@ga-fleury
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

Rename the following CSS classes and references to them:

  • .blockly-icon-comment -> blocklyCommentIcon
  • .blockly-icon-warning -> blocklyWarningIcon
  • .blockly-icon-mutator -> blocklyMutatorIcon

This change should be made against the rc/v12.0.0 branch. This should be marked as a breaking change.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@ga-fleury
Copy link

Hey @BeksOmega, I'd like to work on this

ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 12, 2024
@ga-fleury
bug: Rename the blockly icon CSS classes to use camelCase (google#8329)
7fb71c1
@ga-fleury ga-fleury mentioned this issue Jul 12, 2024
Merged
1 task
@BeksOmega
Copy link
Collaborator Author

Sweet, thanks for the comment @ga-fleury =)

BeksOmega pushed a commit that referenced this issue Jul 12, 2024
@ga-fleury
bug: Rename the blockly icon CSS classes to use camelCase (#8329) (#8335
9ba791c 
)
@BeksOmega BeksOmega added size: small Bugs that can be picked up and completed in 1-3 days and removed good first issue labels Aug 13, 2024
@gonfunko gonfunko closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ga-fleury ga-fleury

Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
None yet
Milestone
v12
Development

No branches or pull requests
3 participants
@gonfunko @BeksOmega @ga-fleury