Disconnect child block before trying to connect #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
Aug 28, 2019
core/keyboard_nav/navigation.js
Outdated
| Blockly.navigation.disconnectChild_ = function(movingConnection, destConnection) { | ||
| var movingBlock = movingConnection.getSourceBlock(); | ||
| var destBlock = destConnection.getSourceBlock(); | ||
| var disconnectConnection = null; |
There was a problem hiding this comment.
disconnectConnection isn't actually be used (it's never set). Remove here and the if statement for it below.
RoboErikG
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Trying to connect the above scenario was throwing an error in block.setParent because we can not set the parent's svgRoot a one of its children.Proposed Changes
Disconnect the child block before connecting.
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information