Fixes toolbox and menu dropdown on mobile. #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that bindEventWithChecks doesn't have anything in the touch map for clicks. But that doesn't seem like an issue. This looks reasonable, though mocha is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Toolbox doesn't click on IOS.
Long dropdown's can't be scrolled.
Proposed Changes
I can't find a reason for using mousedown on these elements since all we're after is detecting a click. A click works universally, so going with that instead.
@rachel-fenichel can you think of a reason to do mouseover > click?
Reason for Changes
Fix mobile
Test Coverage
Tested on:
Desktop Chrome
Desktop Safari
IOS