Fix cursor rendering #2932
Merged
Fix cursor rendering #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/keyboard_nav/cursor_svg.js
Outdated
| newParent.appendChild(svgRoot); | ||
| if (this.isMarker_) { | ||
| for (var i = 0, childNode; childNode = newParent.childNodes[i]; i++) { | ||
| if (childNode.className.baseVal == Blockly.CursorSvg.CURSOR_CLASS) { |
There was a problem hiding this comment.
Blockly.utils.dom.hasClass(childNode , Blockly.CursorSvg.CURSOR_CLASS)
| } | ||
| newParent.insertBefore(svgRoot, cursorNode); | ||
| } else { | ||
| newParent.appendChild(svgRoot); |
There was a problem hiding this comment.
Just to clarify, is this just trying to make sure that the marker cursor comes before the cursor cursor?
There was a problem hiding this comment.
Yup, otherwise the marker will cover the cursor and you won't be able to see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
The cursor should always be shown on top of the marker so that it does not disappear when a user marks a connection.
Proposed Changes
Update the position of the marker and the cursor in the dom so that the cursor is always after the marker.
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information