Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make statement inputs store their actual width. #2944

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #2821

Proposed Changes

Statement inputs now extend to the right side of the block:
image

Note that the width of a statement input does not go past the width of a block:
image

But the bounding boxes of the rows-with-children and blocks-with-children are correct:
image

Reason for Changes

Now the statement input can be responsible for drawing its bottom out to the right side, and that means Sam can add rounded corners on the statement input.

Test Coverage

Looked at it in all three renderers, and in geras in RTL, and it looked reasonable.
Checked that block bounds with connected blocks are still right.

@samelhusseini samelhusseini merged commit 4dfb03a into google:develop Aug 31, 2019
@rachel-fenichel rachel-fenichel deleted the statement_input_width branch July 9, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants