Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a build debug npm script for convenience #2961

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Add a build debug npm script for convenience #2961

merged 1 commit into from
Sep 3, 2019

Conversation

samelhusseini
Copy link
Contributor

@samelhusseini samelhusseini commented Sep 3, 2019 •
edited
Loading

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Conviniently run:

npm run build:debug

and look at build-debug.log for the closure compiler output with warnings.

build-debug.log ignored from git.

Reason for Changes

Useful for both internal and external developers to easily check their changes against the closure compiler.

@samelhusseini samelhusseini merged commit dc8d273 into google:develop Sep 3, 2019
@samelhusseini samelhusseini deleted the build-debug branch September 3, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

@rachel-fenichel rachel-fenichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samelhusseini @rachel-fenichel