Move right corner support to common rendering. #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight corner element, square by default.
samelhusseini
commented
Oct 22, 2019
| outlinePath += this.constants_.OUTSIDE_CORNERS.bottomLeft; | ||
| } else if (Blockly.blockRendering.Types.isRightRoundedCorner(elem)) { | ||
| outlinePath += this.constants_.OUTSIDE_CORNERS.bottomRight; | ||
| rightCornerYOffset = this.constants_.OUTSIDE_CORNERS.rightHeight; |
There was a problem hiding this comment.
Note, the right corner Y offset was this.constants_.INSIDE_CORNERS.rightHeight in zelos, but this was a bug. It should be attached to the OUTSIDE_CORNER height, so I changed it to this.constants_.OUTSIDE_CORNERS.rightHeight.
rachel-fenichel
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Resolves #3296
Proposed Changes
Might right corner support to common rendering. Making it so there's always a right corner element. Square by default. Extended to be round in Zelos.
Reason for Changes
Making it easier to add right corners in extension renderers.
Test Coverage
Tested geras and zelos rendering in playground. Remains the same.
Added zelos top row and bottom row to minimalist renderer and got rounded corners on both sides.
Tested on:
Documentation
Additional Information