Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp blocks compile build #3519

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

samelhusseini
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

#3518

Proposed Changes

Fix gulp compile build of blocks, by ensuring all added provides are included in the remove regex.

Reason for Changes

Fix gulp build.

Test Coverage

Tested demos and playground with both uncompressed and compressed builds.

Tested on:

Documentation

Additional Information

@samelhusseini samelhusseini merged commit 034ae87 into google:develop Dec 16, 2019
@samelhusseini samelhusseini deleted the fix_gulp_build branch December 16, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants