Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marker css #3745

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix marker css #3745

merged 2 commits into from
Mar 12, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #3744

Proposed Changes

Add pointer-events none

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

@@ -569,7 +569,8 @@ Blockly.blockRendering.MarkerSvg.prototype.createDomInternal_ = function() {
{
'class': 'blocklyVerticalMarker',
'rx': 10, 'ry': 10,
'style': 'display: none'
'style': 'display: none',
'pointer-events': 'none'
Copy link
Contributor

@samelhusseini samelhusseini Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this move to blocklyVerticalMarker in css.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! updated.

@alschmiedt alschmiedt merged commit 877063b into google:develop Mar 12, 2020
@alschmiedt alschmiedt deleted the fix_keyboard_bug branch May 29, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants