Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field colour in headless #3795

Merged

Conversation

samelhusseini
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #3794

Proposed Changes

Check if headless.

Reason for Changes

Bug fix.

Test Coverage

Tested on:

Documentation

Additional Information

Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on why the tests didn't catch this?

@samelhusseini
Copy link
Contributor Author

Yes, tests don't set the source block. Follow up PR coming that addresses that (I just wanted to keep the two separate to make it easier to cherry pick this)

@samelhusseini samelhusseini merged commit 06f6c22 into google:develop Apr 3, 2020
@samelhusseini samelhusseini deleted the fix_field_colour_headless branch April 3, 2020 21:36
samelhusseini added a commit to samelhusseini/blockly that referenced this pull request Apr 3, 2020
samelhusseini added a commit that referenced this pull request Apr 3, 2020
* Fix field colour in headless (#3795)

* Rebuild

* Bump

* Rebuild after bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants