feat: Add margin around zoomToFit #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/workspace_svg.js
Outdated
| /** | ||
| * Margin around the top/bottom/left/right after a zoomToFit call. | ||
| */ | ||
| this.zoomToFitMargin = 20; |
There was a problem hiding this comment.
This can be a module-internal constant instead of being a property on WorkspaceSvg.
There was a problem hiding this comment.
The purpose of this PR was to create a configurable margin.
Original message: https://groups.google.com/g/blockly/c/usQGbD3Ly3U
A constant would not be configurable by developers.
Are we thinking that the margin should be fixed?
There was a problem hiding this comment.
Yeah, I read it as a request for any margins (to make it look better) rather than configurable margins.
rachel-fenichel
approved these changes
Apr 4, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to 20px.