chore: remove instances of AnyDuringMigration in icons code #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.bubble_ = null; | ||
| if (this.bubble_) { | ||
| this.bubble_.dispose(); | ||
| this.bubble_ = null; |
There was a problem hiding this comment.
Why do you still need to set this.bubble_ to null here?
There was a problem hiding this comment.
This is just disposing of the bubble, not the whole icon. So we need to make sure to drop references to the bubble so it can be disposed.
| if (!this.isVisible()) { | ||
| return; | ||
| } | ||
| if (!this.bubble_) return; |
There was a problem hiding this comment.
Why switch from isVisible() to bubble_ for the check?
There was a problem hiding this comment.
So typescript can know that this.bubble_ is defined for the this.bubble_.getBubbleSize() call
rachel-fenichel
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #5857
Proposed Changes
Removes instances of AnyDuringMigration and replaces them with better types where applicable.
Also makes some private things actually
private.Behavior Before Change
No change in behavior.
Behavior After Change
No change in bheavior.
Reason for Changes
Types are fun!
Test Coverage
N/A
Documentation
N/A
Additional Information
I didn't fix the
Pid_type in mutator because I still don't know how to properly typesetTimeoutreturn values.