Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove AnyDuringMigration from the insertion marker manager #6398

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #5857

Proposed Changes

Removes AnyDuringMigration from the insertion marker manager.

Behavior Before Change

Should be no change in behavior

Behavior After Change

Should be no change in behavior.

Reason for Changes

Types are fun :D

Test Coverage

Did a basic manual test of insertion markers, and they seem to work.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner August 30, 2022 20:13
@BeksOmega BeksOmega requested a review from gonfunko August 30, 2022 20:13
@BeksOmega BeksOmega merged commit 21237c9 into google:develop Aug 31, 2022
@BeksOmega BeksOmega deleted the fix/any-insertion branch October 4, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants