chore: remove AnyDuringMigration from common renderer #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Sep 2, 2022
4 tasks
BeksOmega
force-pushed
the
fix/any-common-renderer
branch
from
eebb0de to
6d87b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #5857
Proposed Changes
Removes
AnyDuringMigrationfrom the common renderer code.Behavior Before Change
Should be no change in behavior.
Behavior After Change
Should be no change in behavior.
Reason for Changes
Types are fun!
Test Coverage
Tested that the geras and zelos renderers look correct.
Documentation
N/A
Additional Information
N/A