feat: add basic observable implementations of procedure interfaces #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BeksOmega
force-pushed
the
feat/procedure-models-implementions
branch
from
2a6b864 to
76583a0
Compare
BeksOmega
force-pushed
the
feat/procedure-models-implementions
branch
3 times, most recently
from
09a2dae to
b3dc7bb
Compare
BeksOmega
force-pushed
the
feat/procedure-models-implementions
branch
from
3d1748e to
d44b501
Compare
maribethb
approved these changes
Oct 13, 2022
cpcallen
reviewed
Oct 14, 2022
| constructor( | ||
| private readonly workspace: Workspace, name: string, id?: string) { | ||
| this.id = id ?? genUid(); | ||
| this.variable = workspace.createVariable(name); |
There was a problem hiding this comment.
Shouldn't this try .getVariable(name) first, like setName does? And is there a way of doing that by calling setName—i.e., can tsc infer (or be made to infer) that setName does the initialisation on behalf of the constructor?
(Aside: the latter is the sort of thing I bet Ezno can handle no problem, no special annotation required…)
There was a problem hiding this comment.
I will look into this.
This was referenced Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6514
Dependent on #6488
Proposed Changes
Adds some basic implementations of the procedure interfaces. They don't do any of the important stuff yet (i.e. triggering
doProcedureUpdateor firing events).Reason for Changes
Interfaces need to be implemented.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A