Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 'fixes' to PR template #6616

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

N/A

Proposed Changes

Adds the "fixes" keyword to the PR template.

Reason for Changes

Makes it harder to forget to link an issue.

Additional Information

This won't actually effect anything until this gets merged into master. But I didn't know if we wanted to do that right now, so I'm putting it up against develop.

@BeksOmega BeksOmega requested a review from a team as a code owner November 11, 2022 19:03
@BeksOmega BeksOmega requested a review from maribethb November 11, 2022 19:03
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Nov 11, 2022
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's put it in master

@BeksOmega BeksOmega force-pushed the chore/update-pr-template branch from 131d274 to ae5e86b Compare November 14, 2022 19:06
@BeksOmega BeksOmega changed the base branch from develop to master November 14, 2022 19:06
@BeksOmega BeksOmega merged commit a6bc903 into google:master Nov 14, 2022
@BeksOmega BeksOmega deleted the chore/update-pr-template branch May 3, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants