docs(messages): Add a msg/json/README.md #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a README.md file to msg/json/ explaining the purpose of the files therein, mentioning that PRs are not accepted but that translation updates should be made via TranslateWiki, and with a short description of how to build the langfiles that are generated from them.
github-actions
bot
added
PR: docs
and removed
PR: chore
NeilFraser
approved these changes
Nov 17, 2022
Oh yeah. I totally meant to mention that. Let me fix that. |
cpcallen
force-pushed
the
messages-readme
branch
from
5e9b23b to
dbd6eb8
Compare
|
@NeilFraser: I've updated the message. Preview here. Re-review please. |
|
LGTM
Sent (awkwardly) from an Android device.
…On Thu, 17 Nov 2022, 23:12 Christopher Allen, ***@***.***> wrote:
@NeilFraser <https://github.com/NeilFraser>: I've updated the message. Preview
here
<https://github.com/cpcallen/blockly/blob/messages-readme/msg/json/README.md>
.
Re-review please.
—
Reply to this email directly, view it on GitHub
<#6635 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5E4BYTDVN2FR5V44GS6TWI2UVFANCNFSM6AAAAAASDZ2DII>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Proposed Changes
Add a README.md file to msg/json/ explaining the purpose of the files therein, mentioning that PRs are not accepted but that translation updates should be made via TranslateWiki, and with a short description of how to build the langfiles that are generated from them.
Behaviour Before Change
Well-meaning external contributors send us PRs with translation corrections.
Behaviour After Change
With luck: well-meaning external contributors instead use TranslateWiki to submit translation updates.
Reason for Changes
Avoid wasting their (and our) time with PRs that we cannot accept.
Documentation
Yes.