fix: Make metadata tests more resilient. #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#6768
Proposed Changes
This PR updates the metadata test to verify that the previous size of the files is not undefined, in order to trigger an explicit test failure in the situation reported in #6768. It also updates the check_metadata.sh file to remove errant whitespace before the file sizes that was causing the regex in test_tasks.js to fail to identify the old file sizes when running the test. Finally, it updates update_metadata.sh to strip whitespace when updating the file sizes in check_metadata.sh to avoid this issue recurring.
Behavior Before Change
Metadata test scripts didn't actually check the change in filesize and passed regardless.
Behavior After Change
Metadata test scripts work properly.