fix!: rendered meaning
#7747
Merged
fix!: rendered meaning
#7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking change
github-actions
bot
added
breaking change
1 task
github-actions
bot
added
breaking change
BeksOmega
force-pushed
the
fix/block-initialization-2
branch
from
3998b14 to
e0f9525
Compare
github-actions
bot
added
breaking change
github-actions
bot
added
breaking change
BeksOmega
force-pushed
the
fix/block-initialization-2
branch
from
e0f9525 to
902aeae
Compare
github-actions
bot
added
breaking change
maribethb
reviewed
Jan 10, 2024
| @@ -123,7 +123,6 @@ export class Input { | |||
|
|
|||
| if (this.sourceBlock.rendered) { | |||
There was a problem hiding this comment.
would it be possible to just check instanceof BlockSvg then you wouldn't need to cast either? circular dependencies are the only reason i can think of you wouldn't do that but i'm hoping that doesn't apply here
There was a problem hiding this comment.
It causes circular dependencies.
maribethb
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #4288
Proposed Changes
Makes it so that
renderedis constant, and is only used to check whether the block is aBlockor aBlockSvg.Reason for Changes
Makes the system easier to reason about and understand.
Test Coverage
Fixed change detectors.
Documentation
This will need docs. I have separate tasks filed for that.
Additional Information
This PR creates a pretty significant performance degredation related to
bumpNeighboursI have a separate fix in the works for that. But in an effort to keep my PRs small I'm putting that up separately.There's also more work to be removing references to
initSvgandrenderedand cleaning upinitSvg.Dependent on #7745
Breaking changes / To fix
If you are using
renderedto check whether the block is initialized or currently visible, do not do that.renderedshould only be used to tell if the block is aBlockinstance or aBlockSvginstance.If you are setting
renderedto temporarily disable rendering and improve performance, that is no longer necessary because we perform rendering batching.If you have another use case for accessing
renderedthat is not covered here, please let us know on the forum.