Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update git url #8169

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: update git url #8169

merged 1 commit into from
May 21, 2024

Conversation

maribethb
Copy link
Contributor

The basics

The details

Resolves

Fixes this warning when publishing:

npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish Removed invalid "scripts"
npm WARN publish "repository.url" was normalized to "git+https://github.com/google/blockly.git"

Proposed Changes

Runs npm pkg fix and commits that change -- it doesn't tell me what the "invalid scripts" are but none are removed. fwiw I ran the command in the dist directory too and there already aren't any scripts in that package.json so 🤷‍♀️

Reason for Changes

release follow up

Test Coverage

Documentation

Additional Information

@maribethb maribethb requested a review from a team as a code owner May 21, 2024 21:17
@maribethb maribethb requested a review from BeksOmega May 21, 2024 21:17
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label May 21, 2024
@BeksOmega
Copy link
Collaborator

Reasoning for the scripts warning: npm/cli#6918 (comment)

This is a side effect of how npm has been publishing packuments this whole time.
If you inspect the packages in the registry, you'll see they all have an empty scripts object even if the package.json source does not.
The new logging is a byproduct of our attempts to make sure these two entries are in sync. The decision was made to NOT allow a change change to what's in the registry to minimize potential breaking changes for those who consume these packages.

The git+ change is a no-op as far as I can tell. So I don't think this change is necessary, or will resolve the warnings. But approving in case it does.

@maribethb
Copy link
Contributor Author

Thanks for the link! It sounds like we'd need to add an empty scripts property to the package.json file that we generate in dist to completely get rid of the warning, which is dumb (and a misleading warning)

but I'm pretty sure this will at least remove the bit about the url being normalized, and as you said, shouldn't have any other effect

@maribethb maribethb merged commit d7d5b9a into google:develop May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants