Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Rename editing CSS class to blocklyEditing (#8287) #8301

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix!: Rename editing CSS class to blocklyEditing (#8287) #8301

merged 2 commits into from
Jul 22, 2024

Conversation

ga-fleury
Copy link

@ga-fleury ga-fleury commented Jul 11, 2024 •
edited by BeksOmega
Loading

Fixes: #8287

chore!: Rename editing CSS class to blocklyEditing (#8287)

@ga-fleury ga-fleury requested a review from a team as a code owner July 11, 2024 00:48
@ga-fleury ga-fleury requested a review from cpcallen July 11, 2024 00:48
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Jul 11, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleury ga-fleury changed the title chore!: Rename editing CSS class to blocklyEditing (#8287) chore!: Rename editing CSS class to blocklyEditing Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleury ga-fleury changed the title chore!: Rename editing CSS class to blocklyEditing Rename editing CSS class to blocklyEditing Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleury ga-fleury changed the title Rename editing CSS class to blocklyEditing chore!: Rename editing CSS class to blocklyEditing Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleury ga-fleury changed the title chore!: Rename editing CSS class to blocklyEditing chore!: Rename editing CSS class to blocklyEditing (#8287) Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@cpcallen cpcallen assigned BeksOmega and unassigned cpcallen Jul 11, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@BeksOmega
Copy link
Collaborator

Yay! Glad it looks like you got the branches sorted :D

Two housekeeping things that apply to all of your PRs:

  1. Commenting on issues is important. Even if I don't assign it to you before you complete it, it lets other folks know it is being worked on, so they can look at other issues.
  2. Filling out the PR template is important. At the bare minimum you need the Fixes: #issue line, because there is GitHub automation associated with that. I'll fix your existing PRs, but for any future PRs you'll have to do this.

Please reply or react to let me know you've seen this!

@ga-fleury
Copy link
Author

Yay! Glad it looks like you got the branches sorted :D

Two housekeeping things that apply to all of your PRs:

  1. Commenting on issues is important. Even if I don't assign it to you before you complete it, it lets other folks know it is being worked on, so they can look at other issues.
  2. Filling out the PR template is important. At the bare minimum you need the Fixes: #issue line, because there is GitHub automation associated with that. I'll fix your existing PRs, but for any future PRs you'll have to do this.

Please reply or react to let me know you've seen this!

Will do! thank you for the heads up!

@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 11, 2024 16:58
BeksOmega
BeksOmega requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this in the issue description, but there is also a places in core/field_input where we call dom.removeClass with editing. This needs to be renamed as well.

After that should be gtg!

@BeksOmega
Copy link
Collaborator

Heya @ga-fleury Are you still interested in working on this?

@ga-fleury
Copy link
Author

@BeksOmega added further changes

BeksOmega
BeksOmega approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fixes =)

@BeksOmega BeksOmega changed the title chore!: Rename editing CSS class to blocklyEditing (#8287) fix!: Rename editing CSS class to blocklyEditing (#8287) Jul 22, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 22, 2024
@BeksOmega BeksOmega merged commit e29d7ab into google:rc/v12.0.0 Jul 22, 2024
8 checks passed
@BeksOmega BeksOmega mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ga-fleury @BeksOmega @cpcallen