Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added blocklyTrashcanFlyout CSS class #8372

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

ChaitanyaYeole02
Copy link

The basics

The details

Resolves

Feature Request #8342

Proposed Changes

Add a blocklyTrashcanFlyout CSS class to the flyout if it is used by the trashcan

@ChaitanyaYeole02 ChaitanyaYeole02 requested a review from a team as a code owner July 15, 2024 23:28
Copy link

google-cla bot commented Jul 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@ChaitanyaYeole02 ChaitanyaYeole02 changed the title feature/#8342 Added blocklyTrashcanFlyout CSS class to the flyout feat: Added blocklyTrashcanFlyout CSS class Jul 15, 2024
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 15, 2024
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 16, 2024 15:38
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Jul 16, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix. Once CI passes I'll get this merged =)

@ChaitanyaYeole02
Copy link
Author

ChaitanyaYeole02 commented Jul 16, 2024

@BeksOmega When I am running npm run format:check
image
I am receving no errors.

Inside the CI, when I go into details it tells me that this command is failing.

What am I missing?

@BeksOmega
Copy link
Collaborator

Hello, when I pull down your branch and run the command I get the same error as we're seeing on CI. Perhaps you have a different version of prettier installed? Can you run npn ci in the console and then npm run format?

@ChaitanyaYeole02
Copy link
Author

Hello, when I pull down your branch and run the command I get the same error as we're seeing on CI. Perhaps you have a different version of prettier installed? Can you run npn ci in the console and then npm run format?

npm ci gives me few deprecated warning and few vulnerabilities.
npm run format this still gives me no errors

@BeksOmega
Copy link
Collaborator

Thank you again!

@BeksOmega BeksOmega merged commit e298f55 into google:rc/v12.0.0 Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants