fix: Fix unsafe cast in Input.setVisible(). #8695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It said it would throw, ie that was the previous behavior, and it now no-ops aside from setting the visiblity status, which should be reflected when the block finishes initing. |
|
Ah, I misread. Thanks. |
rachel-fenichel
approved these changes
Jan 6, 2025
No worries, it was kind of an awkward phrasing on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8694
Proposed Changes
This PR checks if the connection in Input.setVisible() is actually a rendered connection before assuming it is. If
setVisible()was called while initing a block, connections may not have been fully set up and this would throw.