Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Commit

Permalink
Fixing issue that was preventing placement pricing schedule to load
Browse files Browse the repository at this point in the history
Change-Id: I7d037579a85aa33ba1ddfcee7b173df71d392b32
  • Loading branch information
mauriciodesiderio committed Jul 13, 2021
1 parent 363b03c commit 87c1642
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
10 changes: 8 additions & 2 deletions Loaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -1617,7 +1617,6 @@ var PlacementLoader = function(cmDAO) {

processActiveViewAndVerification(job);


if(job.processPricingSchedule) {
this.processPricingSchedule(job);
}
Expand Down Expand Up @@ -1647,6 +1646,14 @@ var PlacementLoader = function(cmDAO) {
pricingSchedulePostProcess(job);
}
}

/**
* @see AdLoader.preparePushJob
*/
this.preparePushJob = function(job, pushJob) {
pushJob.processPricingSchedule = job.processPricingSchedule;
}

}
PlacementLoader.prototype = Object.create(BaseLoader.prototype);

Expand Down Expand Up @@ -1882,7 +1889,6 @@ var CreativeLoader = function(cmDAO) {
this.processPush = function(job) {
var creative = job.cmObject;
var feedItem = job.feedItem;
console.log(feedItem);

if(feedItem[fields.creativeName]) {
creative.name = feedItem[fields.creativeName];
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Use the links below to navigate to each one of the tools available. Refer to the

- [Bulkdozer
Lite
0.37](https://docs.google.com/spreadsheets/d/1ZDXUZe-N468c4Gkk_p6qsgBkR2MGBi-qUAQfkvnkBhY/edit?usp=sharing&resourcekey=0-o7HLnGqg-Qz7vZykVC9AQg)
0.38](https://docs.google.com/spreadsheets/d/1n2dqrq0iryC2OjKYP2jL--VYNf5JAhkmMf2zpMCUmE4/edit?usp=sharing)
- [QA
Tools
0.14](https://docs.google.com/spreadsheets/d/1dAoERvFTaTyrNXv88MLIiKnU1NvSsNYc0oKf7Tm6zwo)
Expand Down
2 changes: 1 addition & 1 deletion appsscript.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"enabledAdvancedServices": [{
"userSymbol": "DoubleClickCampaigns",
"serviceId": "dfareporting",
"version": "v3.4"
"version": "v3.5"
}]
},
"exceptionLogging": "STACKDRIVER",
Expand Down
3 changes: 2 additions & 1 deletion sidebar.html
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,8 @@
jobsMap[job['entity']].jobs = pushJobs[0].jobs;

if(jobsMap[job['entity']].jobs.length > 0) {
return new Runner().run('cmPush', preparePushJob(jobsMap, job['entity'], idMap), writeLogs).then(function(executedJobs) {
var j = preparePushJob(jobsMap, job['entity'], idMap);
return new Runner().run('cmPush', j, writeLogs).then(function(executedJobs) {
jobsMap[job['entity']].jobs = executedJobs;
return postProcessEntityPush(executedJobs);
});
Expand Down

0 comments on commit 87c1642

Please sign in to comment.