-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller extended advertising #238
Open
barbibulle
wants to merge
2
commits into
main
Choose a base branch
from
gbg/controller-extended-advertising
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,10 @@ | |
from bumble.colors import color | ||
from bumble.core import name_or_number | ||
from bumble.hci import ( | ||
HCI_READ_LOCAL_EXTENDED_FEATURES_COMMAND, | ||
HCI_READ_LOCAL_SUPPORTED_FEATURES_COMMAND, | ||
HCI_Read_Local_Extended_Features_Command, | ||
HCI_Read_Local_Supported_Features_Command, | ||
map_null_terminated_utf8_string, | ||
HCI_SUCCESS, | ||
HCI_LE_SUPPORTED_FEATURES_NAMES, | ||
|
@@ -58,6 +62,36 @@ def command_succeeded(response): | |
return False | ||
|
||
|
||
# ----------------------------------------------------------------------------- | ||
async def get_common_info(host): | ||
if host.supports_command(HCI_READ_LOCAL_SUPPORTED_FEATURES_COMMAND): | ||
response = await host.send_command(HCI_Read_Local_Supported_Features_Command()) | ||
if response.return_parameters.status == HCI_SUCCESS: | ||
print() | ||
print(color('LMP Features:', 'yellow')) | ||
# TODO: support printing discrete enum values | ||
print(' ', response.return_parameters.lmp_features.hex()) | ||
|
||
if host.supports_command(HCI_READ_LOCAL_EXTENDED_FEATURES_COMMAND): | ||
response = await host.send_command( | ||
HCI_Read_Local_Extended_Features_Command(page_number=0) | ||
) | ||
if response.return_parameters.status == HCI_SUCCESS: | ||
if response.return_parameters.max_page_number > 0: | ||
print() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the empty line intended? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. That's to ensure a blank line before the section. |
||
print(color('Extended LMP Features:', 'yellow')) | ||
|
||
for page in range(1, response.return_parameters.max_page_number + 1): | ||
response = await host.send_command( | ||
HCI_Read_Local_Extended_Features_Command(page_number=page) | ||
) | ||
|
||
if response.return_parameters.status == HCI_SUCCESS: | ||
# TODO: support printing discrete enum values | ||
print(f' Page {page}:') | ||
print(' ', response.return_parameters.extended_lmp_features.hex()) | ||
|
||
|
||
# ----------------------------------------------------------------------------- | ||
async def get_classic_info(host): | ||
if host.supports_command(HCI_READ_BD_ADDR_COMMAND): | ||
|
@@ -162,6 +196,9 @@ async def async_main(transport): | |
) | ||
print(color(' LMP Subversion:', 'green'), host.local_version.lmp_subversion) | ||
|
||
# Get the common info | ||
await get_common_info(host) | ||
|
||
# Get the Classic info | ||
await get_classic_info(host) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to parse features into
set
orIntFlag
or something else because sometimes we need to check controller capabilities for both dev and product evaluation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'll try to add that in a separate PR.