fix advertising parameter usage for legacy advertising

[markusjellitsch]

when using start_adverting() the usage of advertising_interval_min and advertising_interval_max for legacy advertising is not consistent with extended advertising (The advertising_interval given as input param should be calculated in 0.625 units)

[zxzxwu]

This API has been widely used, so we shouldn't roughly alter its spec. At least we should check its type to determine whether it should be considered 1 or 0.625 ms.

[markusjellitsch]

Yes understand. At the moment it's a bit confusing and inconsistent, when you call start_advertising()and legacy adv is used it is 0.625 ms, for extended adv it is 1.

[barbibulle]

I think the change here makes sense. It was never the intention of the API to accept values in units of 0.625 (as a general rule, the Device API tries to hide internal spec details). All those intervals are supposed to be in milliseconds. In fact, for extended advertising, that's what the implementation does.
So this should be considered a bug fix, not an API change.

[barbibulle]

@markusjellitsch could you run the formatter (check with invoke project.pre-commit for details) so that the linter/formatter checks can pass before we merge the change?