Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off the deprecated package golang.org/x/exp/inotify #1708

Open
yujuhong opened this issue Jul 27, 2017 · 4 comments · Fixed by #1760 or #1916
Open

Migrate off the deprecated package golang.org/x/exp/inotify #1708

yujuhong opened this issue Jul 27, 2017 · 4 comments · Fixed by #1760 or #1916
Labels
kind/cleanup

Comments

@yujuhong
Copy link
Contributor

golang.org/x/exp/inotify has been deleted (see https://github.com/golang/exp/tree/master/inotify)
cadvisor should switch to using fsnotify, or something equivalent.

xref: kubernetes/kubernetes#40123
@dashpole dashpole self-assigned this Aug 25, 2017
dashpole added a commit to dashpole/cadvisor that referenced this issue Sep 20, 2017
@dashpole
fix google#1708; move from inotify to fsnotify
03b03a4
@dashpole dashpole mentioned this issue Sep 20, 2017
Merged
dashpole added a commit to dashpole/cadvisor that referenced this issue Sep 28, 2017
@dashpole
fix google#1708; move from inotify to fsnotify
e23bfe2
dashpole added a commit to dashpole/cadvisor that referenced this issue Sep 28, 2017
@dashpole
fix google#1708; move from inotify to fsnotify
e6b6a1a
dashpole added a commit to dashpole/cadvisor that referenced this issue Nov 17, 2017
@dashpole
Revert "fix google#1708; move from inotify to fsnotify"
6988e70 
This reverts commit e6b6a1a.
dashpole added a commit that referenced this issue Nov 17, 2017
@dashpole
Merge pull request #1807 from dashpole/revert_1760
a27bed7 
Revert "fix #1708; move from inotify to fsnotify"
@dashpole
Copy link
Collaborator

reopening via #1807. Issue: kubernetes/kubernetes#55909

@dashpole dashpole reopened this Nov 17, 2017
@dashpole dashpole mentioned this issue Mar 5, 2018
Closed
dashpole added a commit to dashpole/cadvisor that referenced this issue Mar 22, 2018
@dashpole
Revert "Revert "fix google#1708; move from inotify to fsnotify""
1a1a1c4 
This reverts commit 6988e70.
@dashpole
Copy link
Collaborator

It looks like the switch to fsnotify actually worked... The summary test passes if we use a non-restarting pod, but fails with the current version of the test. The test checks the summary api for pods that restart. But when they restart, we loose metrics for it. I am not sure how it passes when we are using inotify...

@dashpole dashpole mentioned this issue Mar 27, 2018
Merged
@moelsayed moelsayed mentioned this issue Apr 10, 2018
Closed
@dashpole
Copy link
Collaborator

We are still using inotify. Reopening

@dashpole dashpole reopened this Jan 29, 2019
@dashpole dashpole mentioned this issue Jan 29, 2019
Open
@ElCoyote27
Copy link

@dashpole Still fails on RHEL7, see #1843

@dashpole dashpole removed their assignment Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
No milestone
3 participants
@dashpole @ElCoyote27 @yujuhong